downloadFile(): Remove the "locked" (aka "immutable") flag #10414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edolstra
force-pushed
the
remove-downloadFile-locked
branch
3 times, most recently
from
2bb6a2d
to
59185a6
Compare
This was used in only one place, namely builtins.fetchurl with an expected hash. Since this can cause similar issues as described in NixOS#9814 and NixOS#9905 with the "locked" flag for fetchTarball and fetchTree, let's just remove it. Note that if an expected hash is given and the hash algorithm is SHA-256, then we will never do a download anyway if the resulting store path already exists. So removing the "locked" flag will only cause potentially unnecessary HTTP requests (subject to the tarball TTL) for non-SHA-256 hashes.
edolstra
force-pushed
the
remove-downloadFile-locked
branch
from
59185a6
to
d29786f
Compare
|
CC @yshui you might have an opinion on this? |
Ericson2314
reviewed
Apr 12, 2024
| @@ -101,7 +100,7 @@ DownloadFileResult downloadFile( | |||
| inAttrs, | |||
| infoAttrs, | |||
| *storePath, | |||
| locked); | |||
| false); | |||
There was a problem hiding this comment.
Could we also just remove this? Or does something else call it with true?
There was a problem hiding this comment.
It's still used by the Mercurial fetcher, but it's removed in this followup PR: https://github.com/NixOS/nix/pull/10465/files
Ericson2314
approved these changes
Apr 12, 2024
|
We need tests for this, but I am OK until waiting for the follow-up PR that continues overhauling things to get into that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This was used in only one place anymore, namely
builtins.fetchurlwith an expected hash. Since this can cause similar issues as described in #9814 and #9905 with the "locked" flag forfetchTarballandfetchTree, let's just remove it.Note that if an expected hash is given and the hash algorithm is SHA-256, then we will never do a download anyway if the resulting store path already exists. So removing the "locked" flag will only cause potentially unnecessary HTTP requests (subject to the tarball TTL) for non-SHA-256 hashes.
Context
Priorities and Process
Add 馃憤 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.