-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
pathExists: Return false on "/nix/store" in pure mode #10505
Open
edolstra
wants to merge
9
commits into
NixOS:master
Choose a base branch
from
edolstra:pathExists-regression
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Apr 16, 2024
-
pathExists: Return false on "/nix/store" in pure mode
AllowListInputAccessor has the invariant that if a path is accessible, its parent directories are also considered accessible (though reading them only yields the allowed subdirectories). As a result `builtins.pathExists "/nix/store"` returns true. However this wasn't the behaviour of previous path access control, where `builtins.pathExists "/nix/store"` returns false even if a subdirectory of the store is accessible. Fixes NixOS#9672.
Configuration menu - View commit details
-
Copy full SHA for 4065f16 - Browse repository at this point
Copy the full SHA 4065f16View commit details -
tests/functional/restricted.sh: Remove broken test
'--restrict-eval true' was probably not what was intended (i.e. parsing a file named 'true').
Configuration menu - View commit details
-
Copy full SHA for e244309 - Browse repository at this point
Copy the full SHA e244309View commit details -
Restore old behaviour wrt inaccessible parents of accessible paths
E.g. `pathExists` on such parents will return `false`, and `readDir` will fail.
Configuration menu - View commit details
-
Copy full SHA for 702ca51 - Browse repository at this point
Copy the full SHA 702ca51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9668546 - Browse repository at this point
Copy the full SHA 9668546View commit details -
Configuration menu - View commit details
-
Copy full SHA for 978b364 - Browse repository at this point
Copy the full SHA 978b364View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3a6b79 - Browse repository at this point
Copy the full SHA b3a6b79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75a070c - Browse repository at this point
Copy the full SHA 75a070cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 873be03 - Browse repository at this point
Copy the full SHA 873be03View commit details
Commits on Apr 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7a11e60 - Browse repository at this point
Copy the full SHA 7a11e60View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.