Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

pathExists: Return false on "/nix/store" in pure mode #10505

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Commits on Apr 16, 2024

  1. pathExists: Return false on "/nix/store" in pure mode

    AllowListInputAccessor has the invariant that if a path is accessible,
    its parent directories are also considered accessible (though reading
    them only yields the allowed subdirectories). As a result
    `builtins.pathExists "/nix/store"` returns true.
    
    However this wasn't the behaviour of previous path access control,
    where `builtins.pathExists "/nix/store"` returns false even if a
    subdirectory of the store is accessible.
    
    Fixes NixOS#9672.
    edolstra committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    4065f16 View commit details
    Browse the repository at this point in the history
  2. tests/functional/restricted.sh: Remove broken test

    '--restrict-eval true' was probably not what was intended
    (i.e. parsing a file named 'true').
    edolstra committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e244309 View commit details
    Browse the repository at this point in the history
  3. Restore old behaviour wrt inaccessible parents of accessible paths

    E.g. `pathExists` on such parents will return `false`, and `readDir`
    will fail.
    edolstra committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    702ca51 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9668546 View commit details
    Browse the repository at this point in the history
  5. Typo

    edolstra committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    978b364 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b3a6b79 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    75a070c View commit details
    Browse the repository at this point in the history
  8. Fix test

    edolstra committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    873be03 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Reword

    edolstra committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    7a11e60 View commit details
    Browse the repository at this point in the history