doc/glossary: Add base directory #10563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <!-- which is sufficient for resolving non-empty URLs --> | ||
|
|
||
| <!-- note the wording here, because --expr is a flag, and not an option with an argument --> | ||
| - For expressions written in command line arguments with [`--expr`](@docroot@/command-ref/opt-common.html#opt-expr), the base directory is the current working directory. |
There was a problem hiding this comment.
Suggested change
| - For expressions written in command line arguments with [`--expr`](@docroot@/command-ref/opt-common.html#opt-expr), the base directory is the current working directory. | |
| - For expressions passed as command line arguments with [`--expr`](@docroot@/command-ref/opt-common.html#opt-expr), the base directory is the current working directory. |
There was a problem hiding this comment.
Meh, I can't commit myself. Please merge yourself after this fix.
There was a problem hiding this comment.
I've added a comment to clarify the wording:
* "written in": the expression itself must be written as an argument,
whereas the more natural "passed as an argument" allows an interpretation
where the expression could be passed by file name.
fricklerhandwerk
approved these changes
Apr 20, 2024
roberth
force-pushed
the
doc-glossary-base-directory
branch
2 times, most recently
from
f168732
to
fa79f19
Compare
roberth
force-pushed
the
doc-glossary-base-directory
branch
from
fa79f19
to
e8d267a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A more easily defined term that will be of use in
Context
Priorities and Process
Add 馃憤 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.