-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
AttrCursor: Remove forceErrors #10564
Conversation
Actually I am not longer able to reproduce the eval error with nix 2.22.0, also it happens for nix 2.18. Also the test you wrote works even if the fix is not applied. |
@Mic92 I can't reproduce that. The test does fail for me without the fix:
|
Instead, force evaluation of the original value only if we need to show the exception to the user.
d811a40
to
eeb4c40
Compare
Ok. I was able to reproduce this now as well: #10813 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-06-03-nix-team-meeting-minutes-149/46582/1 |
Motivation
This should remove all "cached failure of attribute X" messages by forcing evaluation of the original value when it's needed to show the exception to the user.
Context
Priorities and Process
Add 馃憤 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.