libstore: check additionalSandboxProfile #10652
Merged
+47
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
with-tests
edolstra
reviewed
May 6, 2024
edolstra
reviewed
May 6, 2024
thufschmitt
force-pushed
the
check-additionalSandboxProfile
branch
from
50eab74
to
deef8b6
Compare
Make sure that `extraSandboxProfile` is set before we check whether it's empty or not (in the `sandbox=true` case). Also adds a test case for this. Co-Authored-By: Artemis Tosini <lix@artem.ist> Co-Authored-By: Eelco Dolstra <edolstra@gmail.com>
thufschmitt
force-pushed
the
check-additionalSandboxProfile
branch
from
deef8b6
to
9bd1191
Compare
thufschmitt
added
the
backport 2.18-maintenance
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.18-maintenance
git worktree add -d .worktree/backport-10652-to-2.18-maintenance origin/2.18-maintenance
cd .worktree/backport-10652-to-2.18-maintenance
git switch --create backport-10652-to-2.18-maintenance
git cherry-pick -x 9bd1191fccb80a895af976e2445fb92167d9d2f1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make sure that
extraSandboxProfileis set before we check whether it'sempty or not (in the
sandbox=truecase).Also adds a test case for this.
Co-Authored-By: Artemis Tosini lix@artem.ist
Original code from https://git.lix.systems/lix-project/lix/commit/ecdbc3b207eaec1a2cafd2a0d494bcbabdd60a11, fixed and tested for upstream integration.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.