Content addressing store objects #10722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
force-pushed
the
ca-obj-docs
branch
2 times, most recently
from
d922cf6
to
f18cb05
Compare
Ericson2314
force-pushed
the
ca-obj-docs
branch
3 times, most recently
from
e0c9e21
to
dbbbf3a
Compare
Ericson2314
changed the title
roberth
requested changes
May 20, 2024
| }, | ||
| [&](const DerivationOutput::Deferred &) {}, | ||
| [&](const DerivationOutput::Impure & doi) { | ||
| res["hashAlgo"] = std::string { doi.method.renderPrefix() } + printHashAlgo(doi.hashAlgo); | ||
| res["method"] = std::string { doi.method.render() }; | ||
| res["hashAlgo"] = printHashAlgo(doi.hashAlgo); | ||
| res["impure"] = true; | ||
| }, | ||
| }, raw); |
There was a problem hiding this comment.
Wasn't expecting a behavior change.
Is DerivationOutput JSON exposed to builds? That'd be a problem if so.
Otherwise, please add a release note.
There was a problem hiding this comment.
thought: We should have JSON schemas.
There was a problem hiding this comment.
It is not exposed to builds, thankfully. Just the CLI. (You are thinking of the path-info JSON.)
roberth
reviewed
May 20, 2024
The JSON format no longer uses the legacy ATerm `r:` prefixing nonsese, but separate fields. Progress on NixOS#9866 Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
roberth
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Also, the JSON format no longer uses the legacy ATerm
r:prefixing nonsense, but separate fields.Context
Next item from #6877. Following up on #10479.
Progress on #9866
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.