Document the common --no-build-hook option #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Mar 9, 2022
This allows that the versioning parts for it to actually be correct. Version agnostic serializers are deduped crudely with `#include`, while version-specific ones written separately. For me, there are two main motivations for this: 1. No more perverse incentives. fe1f34f did some awkward things because the serializers did not store the version. I don't want anyone making changes to be pushed towards keeping the serialization logic with the core data types because it's easier. 2. I am confident with the incremental approach I tried out in NixOS#1165, we can get Hydra using `ssh-ng://` (and the `Store` abstraction) pretty quickly. After that, I hope we can deprecate `ssh://` for a few releases and then remove it. I don't want to worry about accidentally changing it / breaking it during that time, and having separated codes ensures it stays out of the way! When the `#include "gen-` is ugly, because `ssh://` is hopefully on its way out, I don't mind so much. Once it is gone, we can get rid of that since we just will have the worker versions of things.
7 tasks
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Mar 9, 2022
This allows that the versioning parts for it to actually be correct. Version agnostic serializers are deduped crudely with `#include`, while version-specific ones written separately. For me, there are two main motivations for this: 1. No more perverse incentives. fe1f34f did some awkward things because the serializers did not store the version. I don't want anyone making changes to be pushed towards keeping the serialization logic with the core data types because it's easier. 2. I am confident with the incremental approach I tried out in NixOS#1165, we can get Hydra using `ssh-ng://` (and the `Store` abstraction) pretty quickly. After that, I hope we can deprecate `ssh://` for a few releases and then remove it. I don't want to worry about accidentally changing it / breaking it during that time, and having separated codes ensures it stays out of the way! When the `#include "gen-` is ugly, because `ssh://` is hopefully on its way out, I don't mind so much. Once it is gone, we can get rid of that since we just will have the worker versions of things.
Ericson2314
added a commit
to Ericson2314/nix
that referenced
this pull request
Mar 25, 2022
This allows that the versioning parts for it to actually be correct. Version agnostic serializers are deduped crudely with `#include`, while version-specific ones written separately. For me, there are two main motivations for this: 1. No more perverse incentives. fe1f34f did some awkward things because the serializers did not store the version. I don't want anyone making changes to be pushed towards keeping the serialization logic with the core data types because it's easier. 2. I am confident with the incremental approach I tried out in NixOS#1165, we can get Hydra using `ssh-ng://` (and the `Store` abstraction) pretty quickly. After that, I hope we can deprecate `ssh://` for a few releases and then remove it. I don't want to worry about accidentally changing it / breaking it during that time, and having separated codes ensures it stays out of the way! When the `#include "gen-` is ugly, because `ssh://` is hopefully on its way out, I don't mind so much. Once it is gone, we can get rid of that since we just will have the worker versions of things.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 24, 2023
This allows that the versioning parts for it to actually be correct. Version agnostic serializers are deduped crudely with `#include`, while version-specific ones written separately. For me, there are two main motivations for this: 1. No more perverse incentives. fe1f34f did some awkward things because the serializers did not store the version. I don't want anyone making changes to be pushed towards keeping the serialization logic with the core data types because it's easier. 2. I am confident with the incremental approach I tried out in NixOS#1165, we can get Hydra using `ssh-ng://` (and the `Store` abstraction) pretty quickly. After that, I hope we can deprecate `ssh://` for a few releases and then remove it. I don't want to worry about accidentally changing it / breaking it during that time, and having separated codes ensures it stays out of the way! When the `#include "gen-` is ugly, because `ssh://` is hopefully on its way out, I don't mind so much. Once it is gone, we can get rid of that since we just will have the worker versions of things.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Apr 15, 2023
This allows that the versioning parts for it to actually be correct. Version agnostic serializers are deduped crudely with `#include`, while version-specific ones written separately. For me, there are two main motivations for this: 1. No more perverse incentives. fe1f34f did some awkward things because the serializers did not store the version. I don't want anyone making changes to be pushed towards keeping the serialization logic with the core data types because it's easier. 2. I am confident with the incremental approach I tried out in NixOS#1165, we can get Hydra using `ssh-ng://` (and the `Store` abstraction) pretty quickly. After that, I hope we can deprecate `ssh://` for a few releases and then remove it. I don't want to worry about accidentally changing it / breaking it during that time, and having separated codes ensures it stays out of the way! When the `#include "gen-` is ugly, because `ssh://` is hopefully on its way out, I don't mind so much. Once it is gone, we can get rid of that since we just will have the worker versions of things.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Apr 17, 2023
This allows that the versioning parts for it to actually be correct. Version agnostic serializers are deduped crudely with `#include`, while version-specific ones written separately. For me, there are two main motivations for this: 1. No more perverse incentives. fe1f34f did some awkward things because the serializers did not store the version. I don't want anyone making changes to be pushed towards keeping the serialization logic with the core data types because it's easier. 2. I am confident with the incremental approach I tried out in NixOS#1165, we can get Hydra using `ssh-ng://` (and the `Store` abstraction) pretty quickly. After that, I hope we can deprecate `ssh://` for a few releases and then remove it. I don't want to worry about accidentally changing it / breaking it during that time, and having separated codes ensures it stays out of the way! Make sure various things are deduplicated with `common_proto`.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Apr 17, 2023
This allows that the versioning parts for it to actually be correct. Version agnostic serializers are deduped crudely with `#include`, while version-specific ones written separately. For me, there are two main motivations for this: 1. No more perverse incentives. fe1f34f did some awkward things because the serializers did not store the version. I don't want anyone making changes to be pushed towards keeping the serialization logic with the core data types because it's easier. 2. I am confident with the incremental approach I tried out in NixOS#1165, we can get Hydra using `ssh-ng://` (and the `Store` abstraction) pretty quickly. After that, I hope we can deprecate `ssh://` for a few releases and then remove it. I don't want to worry about accidentally changing it / breaking it during that time, and having separated codes ensures it stays out of the way! Make sure various things are deduplicated with `common_proto`.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
May 10, 2023
This allows that the versioning parts for it to actually be correct. Version agnostic serializers are deduped crudely with `#include`, while version-specific ones written separately. For me, there are two main motivations for this: 1. No more perverse incentives. fe1f34f did some awkward things because the serializers did not store the version. I don't want anyone making changes to be pushed towards keeping the serialization logic with the core data types because it's easier. 2. I am confident with the incremental approach I tried out in NixOS#1165, we can get Hydra using `ssh-ng://` (and the `Store` abstraction) pretty quickly. After that, I hope we can deprecate `ssh://` for a few releases and then remove it. I don't want to worry about accidentally changing it / breaking it during that time, and having separated codes ensures it stays out of the way! Make sure various things are deduplicated with `common_proto`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1118