Place global lock on fetchGit #2422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukateras
added a commit
to serokell/nixpkgs
that referenced
this pull request
Sep 14, 2018
|
That doesn't seem to resolve the issue completely, so closing until the root cause is found. |
|
Did it solve it partly? For future reference do you have examples on the remaining ones and the fixed one? |
lukateras
added a commit
to serokell/nixpkgs
that referenced
this pull request
Sep 28, 2018
This reverts commit dfe725a. Didn't help.
lukateras
referenced
this pull request
in serokell/serokell-closure
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
fetchGitin CI, and lack of a lock causes irrecoverable issues once in a while: https://gist.github.com/serokell-bot/081bc82276e227fe0f34fdb3cfcf3361There are many things that can go wrong prior to
storeLinkLock, so this places global lock onfetchGit.