Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pathInfoCache: Respect disk cache TTLs #3398 (2.3 backport) #3405

Conversation

@roberth
Copy link
Member

@roberth roberth commented Mar 12, 2020

Backport of #3403 without C++20

@roberth roberth changed the title pathInfoCache: Respect disk cache TTLs #3398 pathInfoCache: Respect disk cache TTLs #3398 (2.3 backport) Mar 12, 2020
@edolstra
Copy link
Member

@edolstra edolstra commented Mar 12, 2020

Hm, this might be a bit too big of a chance for the stable branch... It's also more of a feature rather than a bug fix.

@roberth
Copy link
Member Author

@roberth roberth commented Mar 12, 2020

Caching more would be risky, but this caches less.

narinfo-cache-negative-ttl

The TTL in seconds for negative lookups. If a store path is queried from a substituter but was not found, there will be a negative lookup cached in the local disk cache database for the specified duration.

It does not mention an additional long-lived cache in nix-daemon that can't be cleared.

If the implementation doesn't conform to the docs, isn't that a bug?

@edolstra
Copy link
Member

@edolstra edolstra commented Mar 12, 2020

Nix doesn't have any long-lived processes itself though, so it's not really a bug.

@roberth
Copy link
Member Author

@roberth roberth commented Mar 12, 2020

Isn't nix-daemon a long-lived process that is part of Nix?

@edolstra
Copy link
Member

@edolstra edolstra commented Mar 12, 2020

All the real work is done by the nix-daemon child processes which exist only as long as the connection.

@roberth
Copy link
Member Author

@roberth roberth commented Aug 7, 2020

Will Nix 2.4 be released for NixOS 20.09?

@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Aug 9, 2020

@roberth you mean 3.0? I think we could make that.

@roberth
Copy link
Member Author

@roberth roberth commented Aug 26, 2020

@Ericson2314 branch-off for 20.09 is in about a week. Is that too soon or is the goal to stabilize it during the release month?

@roberth
Copy link
Member Author

@roberth roberth commented Oct 29, 2020

I still have to ask users to patch their system Nix, while this patch has run in production for over half a year. Can it be merged?

@edolstra edolstra merged commit 7f1de4d into NixOS:2.3-maintenance Oct 29, 2020
@roberth
Copy link
Member Author

@roberth roberth commented Oct 29, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants