Make function arguments retain position info #3468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This allows querying the location of function arguments. E.g.
builtins.unsafeGetAttrPos "x" (builtins.functionArgs ({ x }: null))
=> { column = 57; file = "/home/infinisil/src/nix/inst/test.nix"; line = 1; }
infinisil
force-pushed
the
functionArgsPositions
branch
from
b331bcb
to
c34e96f
Compare
|
@edolstra any objections? |
|
Thx! |
Profpatsch
pushed a commit
to infinisil/nixpkgs
that referenced
this pull request
Mar 22, 2022
This uses the levenshtein distance to look through all possible
arguments to find ones that are close to what was requested:
error: Function in /home/infinisil/src/nixpkgs/pkgs/tools/text/ripgrep/default.nix
called without required argument "fetchFromGithub",
did you mean "fetchFromGitHub" or "fetchFromGitLab"?
With NixOS/nix#3468 (in current nixUnstable) the error
message becomes even better, adding line location info
Profpatsch
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Apr 1, 2022
This uses the levenshtein distance to look through all possible
arguments to find ones that are close to what was requested:
error: Function in /home/infinisil/src/nixpkgs/pkgs/tools/text/ripgrep/default.nix
called without required argument "fetchFromGithub",
did you mean "fetchFromGitHub" or "fetchFromGitLab"?
With NixOS/nix#3468 (in current nixUnstable) the error
message becomes even better, adding line location info
github-actions bot
pushed a commit
to arcnmx/nixpkgs-lib
that referenced
this pull request
Apr 2, 2022
This uses the levenshtein distance to look through all possible
arguments to find ones that are close to what was requested:
error: Function in /home/infinisil/src/nixpkgs/pkgs/tools/text/ripgrep/default.nix
called without required argument "fetchFromGithub",
did you mean "fetchFromGitHub" or "fetchFromGitLab"?
With NixOS/nix#3468 (in current nixUnstable) the error
message becomes even better, adding line location info
github-actions bot
pushed a commit
to nix-community/nixpkgs.lib
that referenced
this pull request
Apr 3, 2022
This uses the levenshtein distance to look through all possible
arguments to find ones that are close to what was requested:
error: Function in /home/infinisil/src/nixpkgs/pkgs/tools/text/ripgrep/default.nix
called without required argument "fetchFromGithub",
did you mean "fetchFromGitHub" or "fetchFromGitLab"?
With NixOS/nix#3468 (in current nixUnstable) the error
message becomes even better, adding line location info
github-actions bot
pushed a commit
to nix-community/nixpkgs.lib
that referenced
this pull request
Dec 4, 2022
This uses the levenshtein distance to look through all possible
arguments to find ones that are close to what was requested:
error: Function in /home/infinisil/src/nixpkgs/pkgs/tools/text/ripgrep/default.nix
called without required argument "fetchFromGithub",
did you mean "fetchFromGitHub" or "fetchFromGitLab"?
With NixOS/nix#3468 (in current nixUnstable) the error
message becomes even better, adding line location info
github-actions bot
pushed a commit
to nix-community/nixpkgs.lib
that referenced
this pull request
May 31, 2023
This uses the levenshtein distance to look through all possible
arguments to find ones that are close to what was requested:
error: Function in /home/infinisil/src/nixpkgs/pkgs/tools/text/ripgrep/default.nix
called without required argument "fetchFromGithub",
did you mean "fetchFromGitHub" or "fetchFromGitLab"?
With NixOS/nix#3468 (in current nixUnstable) the error
message becomes even better, adding line location info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows querying the location of function arguments. E.g.
I'll be able to use this in NixOS/nixpkgs#79877 for better error messages