Fix log-prefix of nix build -L
#3661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While playing around with Nix master, I realized that the log-prefix is broken when building a derivation on a remote builder: ``` ~/nixpkgs → ../nix/inst/bin/nix build --experimental-features 'nix-command flakes' -L -f . hello lder0> unpacking sources lder0> unpacking source archive /nix/store/3x7dwzq014bblazs7kq20p9hyzz0qh8g-hello-2.10.tar.gz lder0> source root is hello-2.10 lder0> setting SOURCE_DATE_EPOCH to timestamp 1416139241 of file hello-2.10/ChangeLog lder0> patching sources lder0> configuring lder0> configure flags: --disable-dependency-tracking --prefix=/nix/store/55xlqch5wdc3vbkjl3v47bn5if63n65c-hello-2.10 [1/0/1 built] error: interrupted by the user ``` It seems as the five chars of the string `hello` have been replaced by the builder's name (ssh://builder). I suspect that this is related to `fmt` taking `args` as reference[1]. I'm not sure why, but this can be avoided by not appending another formatted string to `i->s`. I worked around this by modifying `i->s` only once. I can reproduce this on a recent `master`[2] and on a recent `flakes`[3]. In the latter case, e.g. `nix flake check -L` is also affected. [1] 334b8f8 [2] bfa1acd [3] 81cafda
edolstra
added a commit
that referenced
this pull request
Jun 5, 2020
Alternative fix to #3661. The cause was that 'name' is a std::string_view into a temporary which could get overwritten.
|
Thanks, I've fixed this in a different way in 39e84c3. |
|
Thanks, missed that. Your fix is actually way better :) |
|
Yeah, it was a lesson for me that changing the return type of a function from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing around with Nix master, I realized that the log-prefix is
broken when building a derivation on a remote builder:
It seems as the five chars of the string
hellohave been replaced bythe builder's name (ssh://builder). I suspect that this is related to
fmttakingargsas reference[1].I'm not sure why, but this can be avoided by not appending another
formatted string to
i->s. I worked around this by modifyingi->sonly once.
I can reproduce this on a recent
master[2] and on a recentflakes[3]. Inthe latter case, e.g.
nix flake check -Lis also affected.[1] 334b8f8
[2] bfa1acd
[3] 81cafda