baseNameOf: Don't copy paths to the store first #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @edolstra |
shlevy
force-pushed
the
baseNameOf-no-copy
branch
from
098d1d1
to
0ee1ca6
Compare
|
+1 for your semantics. Nix manual mentions only how it affects strings (not paths), so this seems a conservative extension. If accepted, it should be mentioned in docs for |
|
This is probably fine. Though I'm not sure if we should do it before or after the 1.8 release. It's probably better to do it after, so we have some time to notice if anything breaks. |
|
Sure, sounds good. |
|
+1 This is has been annoying me for some time. |
|
This just bit me too |
zolodev
pushed a commit
to zolodev/nix
that referenced
this pull request
Jan 1, 2024
* Rewrite "Set up development environment" The previous version is specific to Python as it uses `buildPythonApplication` instead of `mkShell`. This one is more general but maintains the same Python Flask web application example. * Update pinning-nixpkgs to use 22.11 Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically a breaking change, but I doubt anyone relies on the existing semantics. I'd expect
baseNameOf ./footo be"foo", not"somehash-foo". Currently I'm doingbaseNameOf (toString ./foo)everywhere I needbaseNameOf.