New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test RemoteStore::buildDerivation
#3922
Test RemoteStore::buildDerivation
#3922
Conversation
chmod -R u+w $TEST_ROOT/machine1 || true | ||
chmod -R u+w $TEST_ROOT/machine2 || true | ||
rm -rf $TEST_ROOT/machine0 $TEST_ROOT/machine1 $TEST_ROOT/machine2 | ||
rm -f $TEST_ROOT/result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now run init.sh
before every test so we don't need this.
tests/build-remote.sh
Outdated
builders=( | ||
"ssh://localhost?remote-store=$TEST_ROOT/machine1" | ||
"$TEST_ROOT/machine2 - - 1 1 foo" | ||
"ssh-ng://localhost?remote-store=$TEST_ROOT/machine3?systemFeatures=baz - - 1 1 baz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?systemFeatures=baz
won't work, but it's failing before it even gets that far.
Before, processConnection wanted to know a user name and user id, and `nix-daemon --stdio`, when it isn't proxying to an underlying daemon, would just assume "root" and 0. But `nix-daemon --stdio` (no proxying) shouldn't make guesses about who holds the other end of its standard streams. Now processConnection takes an "auth hook", so `nix-daemon` can provide the appropriate policy and daemon.cc doesn't need to know or care what it is.
745419d
to
877a1b7
Compare
This seems more correct. It also means one can specify the features a store should support with --store and remote-store=..., which is useful. I use this to clean up the build remotes test.
877a1b7
to
5d62fb1
Compare
RemoteStore::buildDerivation
RemoteStore::buildDerivation
-- contains #3923 & #3924
Fix `wopNarFromPath` which needed a `toRealPath`.
5d62fb1
to
d2f2be0
Compare
RemoteStore::buildDerivation
-- contains #3923 & #3924RemoteStore::buildDerivation
-- contains #3923 & #3924
RemoteStore::buildDerivation
-- contains #3923 & #3924RemoteStore::buildDerivation
-- contains #3924
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
RemoteStore::buildDerivation
-- contains #3924RemoteStore::buildDerivation
Oh good, still works. |
Fix
wopNarFromPath
which needed atoRealPath
.