Make the tests depend on the nix executable #4060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is enough. The tests also require corepkgs and the nix-* symlinks. |
thufschmitt
force-pushed
the
installcheck-depends-on-nix
branch
from
8b2e314
to
d4e860a
Compare
|
Indeed. I've added a bunch of missing deps, |
thufschmitt
force-pushed
the
installcheck-depends-on-nix
branch
from
d4e860a
to
2596700
Compare
That way just running `make installcheck` is enough to run them against the actual nix code in the repo
thufschmitt
force-pushed
the
installcheck-depends-on-nix
branch
from
2596700
to
cf16a2f
Compare
|
Rebased on top of master, and checked that |
|
Closing as this isn’t compatible with #4239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way just running
make installcheckis enough to run them against the actual nix code in the repo.(I don't know whether that's actually desirable for everyone. It seems to make sense to me to have this, so opening the PR anyways but feel free to close it if that breaks anything)