nix develop: Preserve stdin with -c
#4233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thufschmitt
requested changes
Nov 9, 2020
src/nix/develop.cc
Outdated
| @@ -437,7 +437,7 @@ struct CmdDevelop : Common, MixEnvironment | |||
| std::vector<std::string> args; | |||
| for (auto s : command) | |||
| args.push_back(shellEscape(s)); | |||
| script += fmt("exec %s\n", concatStringsSep(" ", args)); | |||
| script += concatStringsSep(" ", args); | |||
There was a problem hiding this comment.
exec isn't needed anymore, so I thought I may as well simplify the code (since it's not being used for --phase either). Before, it was necessary for exiting the then-interactive shell.
There was a problem hiding this comment.
I don't have a strong opinion on this, but it seems cleaner to keep it, if only to avoid having a useless bash process lying around while the command is running
There was a problem hiding this comment.
Yeah, why not. Reverted.
Co-authored-by: Théophane Hufschmitt <regnat@users.noreply.github.com>
thufschmitt
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For use in editor integration, I would like to run a derivation taking input from stdin instead of $src, basically
However, this currently breaks because of
nix develop's use of--rcfile: the stdin is executed by the shell instead of being passed to the-ccommand. Not using--rcfilewith-c, just like it's already being done with--phase, fixes this.