Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed #if HAVE_BOEHMGC to #ifdef HAVE_BOEHMGC #4627

Closed
wants to merge 1 commit into from

Conversation

p01arst0rm
Copy link
Contributor

just a small correction to simplify config.h definitions.

@edolstra
Copy link
Member

Hm, what's the simplification to config.h?

@p01arst0rm
Copy link
Contributor Author

Hm, what's the simplification to config.h?

it changes

#define HAVE_BOEHMGC 1

to

#define HAVE_BOEHMGC

its just to make it reflect the rest of the entries in the config header instead of
them looking different, makes things more consistent

@edolstra
Copy link
Member

I don't see any change to config.h? I also don't see the consistency issue, since every other config.h entry looks like this, e.g.:

/* Define to 1 if you have the <aws/s3/S3Client.h> header file. */
#define HAVE_AWS_S3_S3CLIENT_H 1

/* Whether to use the Boehm garbage collector. */
#define HAVE_BOEHMGC 1

/* Define to 1 if you have the <bzlib.h> header file. */
#define HAVE_BZLIB_H 1

/* Define to 1 if you have the <dirent.h> header file, and it defines `DIR'.
   */
#define HAVE_DIRENT_H 1
...

@p01arst0rm
Copy link
Contributor Author

I don't see any change to config.h? I also don't see the consistency issue, since every other config.h entry looks like this, e.g.:

/* Define to 1 if you have the <aws/s3/S3Client.h> header file. */
#define HAVE_AWS_S3_S3CLIENT_H 1

/* Whether to use the Boehm garbage collector. */
#define HAVE_BOEHMGC 1

/* Define to 1 if you have the <bzlib.h> header file. */
#define HAVE_BZLIB_H 1

/* Define to 1 if you have the <dirent.h> header file, and it defines `DIR'.
   */
#define HAVE_DIRENT_H 1
...

ah. maybe i read the config wrong then :). ill double check which markup is supposed to be used.

@p01arst0rm p01arst0rm closed this Mar 16, 2021
@p01arst0rm p01arst0rm deleted the fix-boehmgc-ifdef branch March 16, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants