Show skipped tests and strictDeps = true #4659
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to check the assumption that
utillinuxMinimal
is placed correctly inbuildInputs
rather thannativeBuildInputs
because of NixOS/nixpkgs#117295To my surprise, Nix builds the same with
strictDeps
, despite the fact that it should be innativeBuildInputs
in order to run (unshare
during tests), at least to my understanding.utillinuxMinimal
outputs do not appear in the output closure either, which also seems to suggest that it should be innativeBuildInputs
.@Ericson2314 should
utillinuxMinimal
move tonativeBuildInputs
? Why doesn't this PR break the build?