Implement builtins.floor and builtins.ceil using the C library functions internally
#4787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nctions internally Closes NixOS#4782 Note: even though the type is internally called `NixFloat`, it's actually a `double`.
edolstra
approved these changes
May 10, 2021
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
|
@edolstra thanks! applied the suggestion via github :) |
jonringer
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4782
Note: even though the type is internally called
NixFloat, it'sactually a
double.cc @edolstra @jonringer