Allow running all the tests with the daemon #5058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `NIX_DAEMON_PACKAGE` is set, make all the tests use the Nix daemon. That way we can test every piece of Nix functionality both with and without the daemon. Tests for which using the daemon isn’t possible or doesn’t make sens can selectively be disabled with `needLocalStore`
For some reason, an old socket occasionally stays here on OSX, causing the subsequent tests to fail
thufschmitt
force-pushed
the
test-daemon-everywhere
branch
from
c60185c
to
c2c0dba
Compare
Ericson2314
approved these changes
Jul 27, 2021
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-16/14379/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
NIX_DAEMON_PACKAGEis set, make all the tests use the Nix daemon.That way we can test every piece of Nix functionality both with and without the daemon.
Tests for which using the daemon isn’t possible or doesn’t make sense can selectively be disabled with
needLocalStore.Similarely, tests can enforce a constraint on a new-enough daemon by using
requireDaemonNewerThan 2.4pre_20210714(There’s a few tests that break with the daemon for bad reasons. I didn’t fix these, but they are marked with
buggyNeedLocalStore)Fix #4824