Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libstore: Use unix-dotfile vfs if useSQLiteWAL is false #5475

Merged
merged 1 commit into from Nov 3, 2021

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Nov 3, 2021

Fixes #2357 . cc @wmertens @veprbl

I don't know how to test this, since I don't know how to reproduce the sqlite db corruption issue mentioned in https://nixos.wiki/wiki/Nix_Installation_Guide#NFS . I also rarely write C code so this is probably wrong.

I also hope I got the logic correct.

@wmertens
Copy link
Contributor

wmertens commented Nov 3, 2021

Well, LGTM in any case :) I think the corruption is pretty hard to do but involves 2 writers, perhaps one on NFS and the other on the filesystem.

@doronbehar
Copy link
Contributor Author

Thanks for the approval! Backports: #5490 #5491 .

@tomberek
Copy link
Contributor

This commit makes me think there may be some interesting situations where one can query or use sqlite via the HTTP VFS. This can allow interesting or bulk queries to be run efficiently over a sqlite uploaded to S3/static hosting with Range requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use sqlite dotfile vfs to allow use over NFS
4 participants