Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the flake options work when using the daemon #5504

Merged
merged 1 commit into from Nov 8, 2021

Conversation

thufschmitt
Copy link
Member

When setting flake-local options (with the nixConfig field), forward these options to the daemon in case we’re using one.

This is necessary in particular for options like binary-caches or post-build-hook to make sense.

Fix 343239f#r44356843

When setting flake-local options (with the `nixConfig` field), forward
these options to the daemon in case we’re using one.

This is necessary in particular for options like `binary-caches` or
`post-build-hook` to make sense.

Fix <343239f#r44356843>
Radvendii referenced this pull request Nov 5, 2021
This makes it possible to have per-project configuration in flake.nix,
e.g. binary caches and other stuff:

  nixConfig.bash-prompt-suffix = "�[1;35mngi# �[0m";
  nixConfig.substituters = [ "https://cache.ngi0.nixos.org/" ];
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/bundling-binary-caches-into-flakes/12486/15

@domenkozar
Copy link
Member

domenkozar commented Nov 5, 2021

Nice!

There's still one piece missing, how does one trust the flags in environments without a stdin?

@thufschmitt
Copy link
Member Author

There's still one piece missing, how does one trust the flags in environments without a stdin?

I was actually very frustrated because I knew there was an issue I was meaning to write, and couldn’t remember what it was. Thanks for reminding me :)

(actually there’s another piece missing which is #5505 )

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-21/16032/1

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-hacking-session-recording/16123/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants