Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid runtime references to boost #5915

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Conversation

thufschmitt
Copy link
Member

We explicitly hack around to remove them, so might as well check that the hack is useful.

(Introduced because I feared that the changes of #5906 (comment) would bring back some runtime references)

We explicitly hack around to remove them, so might as well check that
the hack is useful.

(Introduced because I feared that the changes of
#5906 (comment) would bring
back some runtime references)
@thufschmitt
Copy link
Member Author

Looks like this check isn’t totally spurious since it’s failing on OSX :D

I couldn’t dig this too deep since I don’t have a mac handy right now, but it looks like the boost libraries (that we selectively copy at build-time from the boost derivation to avoid having to pull in the whole library) have a self-reference which cause the dependency.

$ strings /nix/store/zkh34cv13gm60rl48g2xbq06nzdq31k3-nix-2.6.0pre20220113_a2811f8/lib/libboost_context.dylib | grep /nix/store/q8pcnpxg8i6ls44c3fxcn26pbxw5smxi-boost-1.69.0                          
/nix/store/q8pcnpxg8i6ls44c3fxcn26pbxw5smxi-boost-1.69.0/lib/libboost_context.dylib

I guess the right call of install_name_tool should fix it

@Mic92
Copy link
Member

Mic92 commented Jan 15, 2022

@thufschmitt ping me on matrix and I can give you shell + root access on a m1 mac.

@thufschmitt
Copy link
Member Author

Thx @Mic92 . I found an old one in the meantime, but I’ll keep that in mind for a next time :)

@edolstra edolstra merged commit 008ddef into master Jan 17, 2022
@edolstra edolstra deleted the disallow-boost-reference branch January 17, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants