Shell completion improvements #6128
Conversation
|
I feel tilde expansion should be done in the shell because it's shell-specific, and the shell knows how to do it correctly (e.g. expand ~user). |
|
It seems like the closest we can get to performing tilde expansion on a word in bash is to use EDIT: ugly because I don't expect |
|
(I mean in the case of flake fragments. For paths we could just defer to the shell's path completion as said in the OP.) |
|
Even for flake fragments I believe it can be deferred until the program is run unless it has a “path:” prefix. How about for now allow the shell to handle this for bare paths without a schema? |
|
I'm not sure what you mean by "allow the shell to handle this". |
Otherwise trying to complete `nix build foo#bar --update-input <Tab>` fails with "unexpected fragment"
Without this, completing `nix eval -f file.nix foo.<Tab>` suggests `bar` instead of `foo.bar`, which messes up the command
I was surprised to see an error mentioning ___COMPLETE___ when trying to complete a flag argument that had no completer implemented
Allows completing `nix why-depends /run/cur<Tab>` to /run/current-system
Allows completing `nix build ~/flake#<Tab>`. We can implement expansion for `~user` later if needed. Not using wordexp(3) since that expands way too much.
Requires moving the MixEvalArgs class from libexpr to libcmd because that's where completeFlakeRef is.
|
How can we move this forward? I think this is already an improvement in every situation, do you still want me to look into the |
| .completer = {[&](size_t n, std::string_view prefix) { | ||
| if (n == 0) { | ||
| if (auto flakeRef = getFlakeRefForCompletion()) | ||
| completeFlakeInputPath(getEvalState(), *flakeRef, prefix); | ||
| } else if (n == 1) { | ||
| completeFlakeRef(getEvalState()->store, prefix); | ||
| } |
There was a problem hiding this comment.
noting that this only works if --override-input is given after the installable. making it work before the installable may require bigger changes so out of scope for this pr as its already an improvement
There was a problem hiding this comment.
Addressed in #6693, but note that this is strongly limited. For example, nix build --override-input foo<Tab> my-flake will treat my-flake as the second argument to --override-input and there's not much we can do about that.
|
ping |
|
fwiw im using this pr but rebased on to master https://github.com/Artturin/nix/commits/completion-rebased (self: super: {
nixVersions = super.nixVersions // {
unstable = super.nixVersions.unstable.overrideAttrs (oldAttrs: {
src = super.fetchFromGitHub {
owner = "artturin";
repo = "nix";
rev = "fdda412f2fea22c89163029dc33d3a5f378315fc";
sha256 = "sha256-oy2JhK+66Tt3ULR2ZJf/ebrLnqvoWLLjHHlr9rpS4Xo=";
};
});
};
}) |
|
Is there something simple that would allow this? |
Doesn't look like a completion problem, but I think you can just remove the |
See individual commits for details.
Regarding d69a111, a possible future improvement would be to rely on the shell for completing paths instead of doing it ourselves. This is non-trivial because we need to be able to complete only directories, and to complete flake names in addition to paths, and I don't know how well bash, zsh and fish support that.