Expand the testing section of the hacking docs #6517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thufschmitt
commented
May 10, 2022
thufschmitt
commented
- Make it clear what the different kind of tests are, where they live and how they can be ran
- Ask people to primarily write unit tests
- Make it clear what the different kind of tests are, where they live and how they can be ran - Ask people to primarily write unit tests
edolstra
reviewed
May 10, 2022
| Nix comes with three different flavors of tests: unit, functional and integration. | ||
|
|
||
| Most tests are currently written as functional tests. | ||
| **However**, it is preferable (as much as it makes sense) to primarily test new code with unit tests. |
There was a problem hiding this comment.
I would leave out this sentence because I don't really agree that unit tests are preferable over functional tests. The latter test what we really care about, namely end-to-end behaviour of the actual tool, rather than internal interfaces.
There was a problem hiding this comment.
Ok, removed in 65a913d (Shame, that was the original motivation for this PR to answer #5377 (comment) 🙃 )
As asked in <#6517 (comment)>
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-30/19112/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.