Preserve TMPDIR on macOS in 'nix shell' #7492
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouk
changed the title
thufschmitt
reviewed
Jan 3, 2023
There was a problem hiding this comment.
I think the fix is correct, but having to save tmpdir in a global variable like that is a bit ugly :/
@edolstra if I understand correctly, the problem with TMPDIR is only for the builders, right? Could we only unset it in the build loop then?
That would be a nice simplification. Otherwise, we're going to need a test case for this. |
fricklerhandwerk
added
bug
macos
|
Triaged in the Nix team meeting:
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-03-03-nix-team-meeting-minutes-37/25998/1 |
fricklerhandwerk
added
the
idea approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See for context: #7491
Closes #7491