New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reword description of how realisation works #7592
reword description of how realisation works #7592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is getting a bit messy. Realisation is defined differently depending on the type of object, but we need all in order to explain nix-store --realise
.
- Realise an output (.drv, outputspec)
- Realise a derivation (.drv, outputspec = all)
- Realise an opaque path
On top of that we have the nix-store --realise
behavior that it realises the derivation only after realising the .drv as an opaque path.
053e09b
to
b0399fa
Compare
b0399fa
to
6abb534
Compare
@roberth addressed the review comments, please check again. |
6abb534
to
de8003f
Compare
de8003f
to
b1b9c68
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-06-05-documentation-team-meeting-notes-52/28937/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-06-22-nix-team-meeting-minutes-65/29643/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the last round of suggestions applied, I approve of this PR. Good improvement!
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-06-26-nix-team-meeting-minutes-66/29650/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-50/29793/1 |
a26be24
to
69391e6
Compare
d3474a5
to
78048a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Close to an approval. I think we need a better description of the build process and sandbox, so I made an issue for that. (Might overlap with the derivation page content; see issue)
Build certificates aren't a thing, so that has to go. We might make it a thing, but not in this PR.
[Nix database]: @docroot@/glossary.md#gloss-nix-database | ||
|
||
The resulting paths are printed on standard output. | ||
For non-derivation arguments, the argument itself is printed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI We've started calling these constant paths in the code. Let's see if that sticks first.
No action needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that name.
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
5e3eec7
to
1ac1817
Compare
this is to make it more readable, more concise and more correct.
This work is sponsored by Antithesis ✨