Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten up the exportReferencesGraph tests #7675

Merged
merged 1 commit into from Jan 24, 2023

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Jan 24, 2023

Motivation

Add an $ at the end of the grep regex. Without it, checkRef foo would always imply checkRef foo.drv. We want to tell these situations apart to more precisely test what is going on.

Context

The came up while @aciceri was kindly helping me out with #7330, in draft PR #7339. Unfortunately the solution I envisioned was not correct, so we'll have to go back to the drawing board. Still, this first commit from that attempt is plain good, and so we should merge it rather than letting it go to waste.

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests
  • documentation in the manual
    • n/a
  • code and comments are self-explanatory
    • test suite assumes grep knowledge
  • commit message explains why the change was made
  • new feature or bug fix: updated release notes
    • n/a

CC @aciceri @L-as

tests/export-graph.sh Outdated Show resolved Hide resolved
Add an `$` at the end of the `grep` regex. Without it, `checkRef foo`
would always imply `checkRef foo.drv`. We want to tell these situations
apart to more precisely test what is going on.
@roberth roberth merged commit 04cc7f9 into NixOS:master Jan 24, 2023
@Ericson2314 Ericson2314 deleted the tighten-export-refs-test branch January 24, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants