nix flakes metadata displays lastModified timestamp of inputs #7729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMHO the input's last modified timestamps is more useful than the timestamp of the lockfile.
edolstra
requested changes
Feb 1, 2023
| prefix + (last ? treeLast : treeConn), input.first, | ||
| (*lockedNode)->lockedRef); | ||
| (*lockedNode)->lockedRef, | ||
| std::put_time(std::localtime(&*lastModified), "%F %T")); |
There was a problem hiding this comment.
This will crash if lastModified is empty. You could use the describe() method in lockfile.cc, which does the following:
auto s = fmt("'%s'", flakeRef.to_string());
if (auto lastModified = flakeRef.input.getLastModified())
s += fmt(" (%s)", std::put_time(std::gmtime(&*lastModified), "%Y-%m-%d"));
wentasah
added a commit
to wentasah/nix
that referenced
this pull request
Jul 9, 2023
|
@wfranzini Do you plan to finish this PR? Feel free to take inspiration (or reuse) wentasah@8702614. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
IMHO the input's last modified timestamps is more useful than the timestamp of the lockfile.
Context
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*