Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile: append manpath for default profile #783

Closed
wants to merge 1 commit into from

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jan 29, 2016

No description provided.

@domenkozar
Copy link
Member

See #229, we should only set it if it already exists

@LnL7
Copy link
Member Author

LnL7 commented Feb 1, 2016

This should fix any issues with duplicates

@edolstra
Copy link
Member

edolstra commented Feb 1, 2016

This still doesn't check whether $MANPATH is already set. We don't want to mess with $MANPATH if it's unset, because that screws up the default man search path (which is derived from $PATH).

@domenkozar
Copy link
Member

Yes, we should check if $MANPATH has any value (instead of current implementation where it check if it already has the value we're expending it to)

@LnL7
Copy link
Member Author

LnL7 commented Feb 4, 2016

The issue with that approach is that $MANPATH probably won't be empty on other platforms, where this will be most useful. What about checking uname -a?

@domenkozar
Copy link
Member

We should append only if it's already set.

@domenkozar domenkozar mentioned this pull request Jul 29, 2016
@domenkozar
Copy link
Member

Closing in favor of #1005

@domenkozar domenkozar closed this Jul 29, 2016
zolodev pushed a commit to zolodev/nix that referenced this pull request Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants