Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote reserved keywords when printing expressions #8110

Merged
merged 3 commits into from
May 9, 2023
Merged

Quote reserved keywords when printing expressions #8110

merged 3 commits into from
May 9, 2023

Commits on May 9, 2023

  1. libexpr: quote reserved keys when printing 

    This fixes a bug in commands like `nix eval' which would emit invalid attribute
sets if they contained reserved keywords such as "assert", "let", etc.

These keywords will not be quoted when printed, making them valid expressions.
All keywords recognized by the lexer are quoted except "or", which does not
require quotation.
    @aakropotkin
    aakropotkin committed May 9, 2023
    Configuration menu
    Copy the full SHA
    b72bc4a View commit details
    Browse the repository at this point in the history

  2. prevent double quotation

    @aakropotkin
    aakropotkin committed May 9, 2023
    Configuration menu
    Copy the full SHA
    82296f8 View commit details
    Browse the repository at this point in the history

  3. quote subshell expansion in tests/eval.sh

    @aakropotkin
    aakropotkin committed May 9, 2023
    Configuration menu
    Copy the full SHA
    82d1d74 View commit details
    Browse the repository at this point in the history