Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for librapidcheck #8190

Merged
merged 2 commits into from Apr 10, 2023
Merged

add check for librapidcheck #8190

merged 2 commits into from Apr 10, 2023

Conversation

NaN-git
Copy link

@NaN-git NaN-git commented Apr 8, 2023

Motivation

So far configure.ac does not check whether librapidcheck can be linked. Also there is no explanation of RAPIDCHECK_HEADERS, which makes proper builds without nix difficult.

Changes

  • add check for librapidcheck
  • declare RAPIDCHECK_HEADERS as variable with help string

Context

The missing library check was discussed in #7809.

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • documentation in the internal API docs
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

Priorities

Add 馃憤 to pull requests you find important.

declare RAPIDCHECK_HEADERS as variable
@NaN-git NaN-git requested a review from edolstra as a code owner April 8, 2023 20:42
@@ -219,6 +219,7 @@

enableParallelBuilding = true;

configureFlags = testConfigureFlags; # otherwise configure fails
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it might be better to instead allow disabling the unit tests without disabling the functional tests.

What do you think, @robert?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Probably meant to ping @roberth?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think improving the granularity is probably good, but I don't think this PR's change affects the need for rebuilds in any significant way, so there's no hurry.

Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Just the one question above from me.

It may make sense to just merge this and return to that after too.

@roberth roberth merged commit a2ec8ea into NixOS:master Apr 10, 2023
15 checks passed
@lf-
Copy link
Member

lf- commented Jun 6, 2023

n.b. I was having configure failures with this check, which were baffling. I traced it down to zsh not expanding $configureFlags to multiple arguments, the fix of which is writing ${=configureFlags} for zsh only. I think I will file a PR adding a note of this to the docs.

@fricklerhandwerk fricklerhandwerk added build-problem Nix fails to compile or test; also improvements to build process tests labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-problem Nix fails to compile or test; also improvements to build process tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants