New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
add check for librapidcheck #8190
Conversation
declare RAPIDCHECK_HEADERS as variable
@@ -219,6 +219,7 @@ | |||
|
|||
enableParallelBuilding = true; | |||
|
|||
configureFlags = testConfigureFlags; # otherwise configure fails |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it might be better to instead allow disabling the unit tests without disabling the functional tests.
What do you think, @robert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Probably meant to ping @roberth?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think improving the granularity is probably good, but I don't think this PR's change affects the need for rebuilds in any significant way, so there's no hurry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! Just the one question above from me.
It may make sense to just merge this and return to that after too.
n.b. I was having configure failures with this check, which were baffling. I traced it down to zsh not expanding $configureFlags to multiple arguments, the fix of which is writing |
Motivation
So far
configure.ac
does not check whether librapidcheck can be linked. Also there is no explanation ofRAPIDCHECK_HEADERS
, which makes proper builds without nix difficult.Changes
Context
The missing library check was discussed in #7809.
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.sh
src/*/tests
tests/nixos/*
Priorities
Add 馃憤 to pull requests you find important.