Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reword documentation on trusted users and substituters #8519

Merged
merged 10 commits into from Jun 23, 2023

Conversation

fricklerhandwerk
Copy link
Contributor

@fricklerhandwerk fricklerhandwerk commented Jun 15, 2023

Motivation

found this while sweeping over open PRs.
this is to make it slightly easier to scan over

This work is sponsored by Antithesis

Priorities

Add 👍 to pull requests you find important.

this is to make it slightly easier to scan over
@github-actions github-actions bot added the new-cli Relating to the "nix" command label Jun 15, 2023
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

Some things I would change, but this is mainly a reflow of the text. I'll save that for later :).

src/nix/daemon.cc Outdated Show resolved Hide resolved
src/nix/daemon.cc Outdated Show resolved Hide resolved
@fricklerhandwerk
Copy link
Contributor Author

@Ericson2314 feel free to make suggestions, we can fix things while they're warm if it doesn't require ripping everything open.

@Ericson2314
Copy link
Member

I am fine just fixing later, it will be easier once we have one sentence per line too. Also @edolstra recently made a PR which this conflicts with. (That PR cleans up the C++ and allows UIDs / GIDs too.) I think it would be good to land this one and that one soon, and then overhaul the docs.

Ericson2314 and others added 2 commits June 15, 2023 07:41
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be helpful to categorize some of these settings as daemon settings and put them on a separate page. That establishes the right expectations and simplifies reading for non-daemon users, trusted users, users of a chroot store, and anyone who doesn't get a permission error.

src/libstore/globals.hh Outdated Show resolved Hide resolved
src/libstore/globals.hh Show resolved Hide resolved
src/libstore/globals.hh Outdated Show resolved Hide resolved
src/nix/daemon.cc Outdated Show resolved Hide resolved
src/nix/daemon.cc Outdated Show resolved Hide resolved
src/nix/daemon.cc Outdated Show resolved Hide resolved
@roberth roberth merged commit fd4f03b into NixOS:master Jun 23, 2023
9 checks passed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-06-22-nix-team-meeting-minutes-65/29643/1

@fricklerhandwerk fricklerhandwerk deleted the reword-trusted-users branch October 9, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants