New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reword documentation on trusted users and substituters #8519
Conversation
this is to make it slightly easier to scan over
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good
Some things I would change, but this is mainly a reflow of the text. I'll save that for later :).
@Ericson2314 feel free to make suggestions, we can fix things while they're warm if it doesn't require ripping everything open. |
I am fine just fixing later, it will be easier once we have one sentence per line too. Also @edolstra recently made a PR which this conflicts with. (That PR cleans up the C++ and allows UIDs / GIDs too.) I think it would be good to land this one and that one soon, and then overhaul the docs. |
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be helpful to categorize some of these settings as daemon settings and put them on a separate page. That establishes the right expectations and simplifies reading for non-daemon users, trusted users, users of a chroot store, and anyone who doesn't get a permission error.
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-06-22-nix-team-meeting-minutes-65/29643/1 |
Motivation
found this while sweeping over open PRs.
this is to make it slightly easier to scan over
This work is sponsored by Antithesis ✨
Priorities
Add 👍 to pull requests you find important.