Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redirect old platform uninstall instruction links #8548

Merged
merged 1 commit into from Jun 20, 2023
Merged

redirect old platform uninstall instruction links #8548

merged 1 commit into from Jun 20, 2023

Conversation

abathur
Copy link
Member

@abathur abathur commented Jun 19, 2023

Motivation

Redirect old to the uninstall instructions broken by moving them to a separate page in #8267. @fricklerhandwerk

Context

The overall section link was redirected in #8286, but platform-specific links (which I give out frequently when I triage installer trouble) weren't included.

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • documentation in the internal API docs
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

Priorities

Add 馃憤 to pull requests you find important.

@abathur
redirect old platform uninstall instruction links
33d3889 
Uninstall instructions were moved to their own page in NixOS#8267. The
overall section link was redirected in NixOS#8286, but platform-specific
links (which I give out frequently when I triage installer trouble)
weren't included.
@abathur
Copy link
Member Author

abathur commented Jun 19, 2023

Since I leave these links in virtually every install issue both here and elsewhere, I guess it would be ideal if this can be ~backported to land in the stable docs quickly.

@fricklerhandwerk fricklerhandwerk added the backport 2.16-maintenance Automatically creates a PR against the branch label Jun 20, 2023
fricklerhandwerk
fricklerhandwerk approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. As they say, good URLs are stable URLs.

@NixOS/nixpkgs-maintainers having a Git hook for checking moved pages or anchors would certainly ease contributor experience, but until then I suppose I'll just write more contributor docs.

@edolstra edolstra merged commit 6a74e88 into NixOS:master Jun 20, 2023
9 checks passed
@github-actions github-actions bot mentioned this pull request Jun 20, 2023
Merged
@github-actions
Copy link

Successfully created backport PR for 2.16-maintenance:

@abathur abathur deleted the fix_uninstall_redirects branch June 20, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fricklerhandwerk fricklerhandwerk fricklerhandwerk approved these changes

Assignees
No one assigned
Labels
backport 2.16-maintenance Automatically creates a PR against the branch documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abathur @fricklerhandwerk @edolstra