Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split testing into its own page in the contribution guide #8571

Merged
merged 2 commits into from Jun 27, 2023

Conversation

Ericson2314
Copy link
Member

Motivation

hacking.md has gotten really big!

Context

Split out from #7954 as requested in #7954 (comment)

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • documentation in the internal API docs
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

Priorities

Add 馃憤 to pull requests you find important.

@Ericson2314
Copy link
Member Author

@fricklerhandwerk I pushed this one to the upstream repo so you can also push to it. If you could do the redirects or anything else you like yourself, that would be much appreciated.

@Ericson2314 Ericson2314 mentioned this pull request Jun 23, 2023
7 tasks
This avoids diff noise when more are added. Unlike with JSON, this is
allowed in JS.
Copy link
Contributor

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@fricklerhandwerk fricklerhandwerk merged commit b8bb802 into master Jun 27, 2023
13 checks passed
@fricklerhandwerk fricklerhandwerk deleted the split-out-testing-page branch June 27, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants