New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to sign path as unprivileged user #8589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfroche
force-pushed
the
sign-paths-as-allowed-user
branch
from
June 27, 2023 10:53
877f7c8
to
d903ba6
Compare
thufschmitt
previously requested changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Can you also add an entry in the release notes (doc/manual/src/release-notes/rl-next.md
)? Otherwise, looks good
jfroche
force-pushed
the
sign-paths-as-allowed-user
branch
from
June 27, 2023 12:12
d903ba6
to
ec5697a
Compare
jfroche
added a commit
to jfroche/queued-build-hook
that referenced
this pull request
Jun 27, 2023
Add example that shows how to sign a package with a key. Waiting for NixOS/nix#8589 to be merged. refs nix-community#12
jfroche
added a commit
to jfroche/queued-build-hook
that referenced
this pull request
Jun 27, 2023
Improve post build script in test to shows how to sign a package. Waiting for NixOS/nix#8589 to be merged. refs nix-community#12
User can now sign path as unprivileged/allowed user refs NixOS#1708
jfroche
force-pushed
the
sign-paths-as-allowed-user
branch
from
June 27, 2023 16:31
ec5697a
to
80c9259
Compare
fricklerhandwerk
added
the
store
Issues and pull requests concerning the Nix store
label
Jun 27, 2023
This was referenced Jul 7, 2023
jfroche
added a commit
to jfroche/queued-build-hook
that referenced
this pull request
Sep 4, 2023
Improve post build script in test to shows how to sign a package. Now that NixOS/nix#8589 is merged, we don't need to declare the user signing the package as a trusted user. refs nix-community#12
jfroche
added a commit
to jfroche/queued-build-hook
that referenced
this pull request
Mar 1, 2024
Improve post build script in test to shows how to sign a package. Now that NixOS/nix#8589 is merged, we don't need to declare the user signing the package as a trusted user. refs nix-community#12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
User should be able to sign path as unprivileged/allowed user
Context
refs #1708
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.sh
src/*/tests
tests/nixos/*
Priorities
Add 馃憤 to pull requests you find important.