Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to sign path as unprivileged user #8589

Merged
merged 1 commit into from Jun 30, 2023

Conversation

jfroche
Copy link
Contributor

@jfroche jfroche commented Jun 27, 2023

Motivation

User should be able to sign path as unprivileged/allowed user

Context

refs #1708

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • documentation in the internal API docs
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

Priorities

Add 馃憤 to pull requests you find important.

Copy link
Member

@thufschmitt thufschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you also add an entry in the release notes (doc/manual/src/release-notes/rl-next.md)? Otherwise, looks good

jfroche added a commit to jfroche/queued-build-hook that referenced this pull request Jun 27, 2023
Add example that shows how to sign a package with a key.

Waiting for NixOS/nix#8589 to be merged.

refs nix-community#12
jfroche added a commit to jfroche/queued-build-hook that referenced this pull request Jun 27, 2023
Improve post build script in test to shows how to sign a package.

Waiting for NixOS/nix#8589 to be merged.

refs nix-community#12
User can now sign path as unprivileged/allowed user

refs NixOS#1708
@jfroche jfroche force-pushed the sign-paths-as-allowed-user branch from ec5697a to 80c9259 Compare June 27, 2023 16:31
@fricklerhandwerk fricklerhandwerk added the store Issues and pull requests concerning the Nix store label Jun 27, 2023
@edolstra edolstra merged commit a0c6173 into NixOS:master Jun 30, 2023
9 checks passed
jfroche added a commit to jfroche/queued-build-hook that referenced this pull request Sep 4, 2023
Improve post build script in test to shows how to sign a package.

Now that NixOS/nix#8589 is merged, we don't need
to declare the user signing the package as a trusted user.

refs nix-community#12
jfroche added a commit to jfroche/queued-build-hook that referenced this pull request Mar 1, 2024
Improve post build script in test to shows how to sign a package.

Now that NixOS/nix#8589 is merged, we don't need
to declare the user signing the package as a trusted user.

refs nix-community#12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
store Issues and pull requests concerning the Nix store tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants