clarify wording on args@ default handling #8596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most importantly use shorter sentences and emphasize the key point that defaults aren't taken into account
|
No one sentence per line? |
Ericson2314
reviewed
Jun 28, 2023
Ericson2314
reviewed
Jun 28, 2023
Ericson2314
reviewed
Jun 28, 2023
Ericson2314
reviewed
Jun 28, 2023
Ericson2314
reviewed
Jun 28, 2023
| > in | ||
| > function {} | ||
| > f {} | ||
| > ```` | ||
| > | ||
| > will evaluate to an empty attribute set. |
There was a problem hiding this comment.
Suggested change
| > will evaluate to an empty attribute set. | |
| > and both expressions will evaluate to: | |
| > | |
| > ```nix | |
| > [ 23 {} ] | |
| > ``` |
roberth
added
documentation
language
Ericson2314
approved these changes
Jul 13, 2023
|
Waiting for @roberth for whether I should add this here. |
roberth
reviewed
Jul 19, 2023
It's very illustrative example I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I got slightly confused about what this was trying to tell me. I wouldn't have understood quickly if I didn't know it beforehand, and it's likely people would glance over it if it sounds hard to grasp.
Context
We recently discussed #1461 and checking the quality of documentation on that topic prompted an update.
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 馃憤 to pull requests you find important.