Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toJSON: Add attribute path to trace #8607

Merged
merged 1 commit into from Jul 31, 2023
Merged

toJSON: Add attribute path to trace #8607

merged 1 commit into from Jul 31, 2023

Conversation

roberth
Copy link
Member

@roberth roberth commented Jun 29, 2023

Motivation

Attribute names weren't printed for errors down in the attrsets (and/or lists).

Context

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • documentation in the internal API docs
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

Priorities

Add 馃憤 to pull requests you find important.

@roberth roberth added error-messages Confusing messages and better diagnostics language The Nix expression language; parser, interpreter, primops, evaluation, etc labels Jun 29, 2023
@github-actions github-actions bot added the tests label Jun 29, 2023
@roberth roberth mentioned this pull request Jun 30, 2023
Merged
7 tasks
@dpulls
Copy link

dpulls bot commented Jul 12, 2023

馃帀 All dependencies have been resolved !

@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Jul 31, 2023
@roberth roberth marked this pull request as ready for review July 31, 2023 11:03
@edolstra edolstra merged commit c0e735f into NixOS:master Jul 31, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fricklerhandwerk fricklerhandwerk Awaiting requested review from fricklerhandwerk

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

Assignees
No one assigned
Labels
error-messages Confusing messages and better diagnostics language The Nix expression language; parser, interpreter, primops, evaluation, etc tests with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roberth @edolstra