Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move BuiltPath to its own header/C++ file in libcmd #8691

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Move BuiltPath to its own header/C++ file in libcmd #8691

merged 1 commit into from
Jul 14, 2023

Conversation

Ericson2314
Copy link
Member

Motivation

It is less important, and used less widely, than DerivedPath.

Context

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • documentation in the internal API docs
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

Priorities

Add 👍 to pull requests you find important.

@Ericson2314
Move BuiltPath to its own header/C++ file in libcmd
2c3fb0e 
It is less important, and used less widely, than `DerivedPath`.
@Ericson2314 Ericson2314 mentioned this pull request Jul 13, 2023
Merged
8 tasks
Dessix
Dessix approved these changes Jul 13, 2023
View reviewed changes
Copy link

@Dessix Dessix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles and seems to work fine for general flake behaviours on x86_64-linux NixOS 23.05. Code appears to be correct and sufficiently unchanged in the refactor.

@roberth roberth merged commit 6d9f1a8 into NixOS:master Jul 14, 2023
8 checks passed
@Ericson2314 Ericson2314 deleted the built-path branch July 14, 2023 11:15
@fricklerhandwerk fricklerhandwerk added the contributor-experience Developer experience for Nix contributors label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dessix Dessix Dessix approved these changes

@roberth roberth roberth approved these changes

@thufschmitt thufschmitt Awaiting requested review from thufschmitt

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

Assignees

@roberth roberth

Labels
contributor-experience Developer experience for Nix contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ericson2314 @Dessix @roberth @fricklerhandwerk