nix/why-depends: fix output of --precise
#8786
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'd like to have a proper output on
nix why-depends --precise
back %)Context
I haven't checked when this was exactly introduced, but on Nix 2.16 I realized that the additional lines inserted when using
--precise
are completely separated from the tree:This is apparently because
std::cout
is buffered and flushed in the end whereas the rest of the output isn't. The fix is rather simple, just uselogger->cout
as it's already the case for the rest of the code.This way we also don't need to insert additional newlines in the
hits
map since that's something the logger takes care of.Also added a small test to make sure that the layout of this is somehow tested to reduce the risk of further regressions here.
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.sh
src/*/tests
tests/nixos/*
Priorities
Add 👍 to pull requests you find important.