Respect NOCOLOR
#9056
Merged
Respect NOCOLOR
#9056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `nix` has always been respectful towards requests for `NO_COLOR=1`, this change asks represents a new stage of maturity for `nix` - making it also respect quests for `NOCOLOR=1`. This ideally makes the tool more accessible to folks like me, who are exhausted by guessing whether `NO_COLOR` or `NOCOLOR` is the right environment variable to set. <3
fricklerhandwerk
added
the
UX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
nixhas always been respectful towards requests forNO_COLOR=1, this change adds respect forNOCOLOR=1.<3
Motivation
This ideally makes the tool more accessible to folks like me, who are exhausted by guessing whether
NO_COLORorNOCOLORis the right environment variable to set.Context
Several tools support both.
Some tools such as
grephave been migrated from supportingNO_COLORover toNOCOLORand emit deprecation warnings.Developers who use multiple machines and a variety of tools might be setting
NO_COLOR=1and/orNOCOLOR=1and expect either/both to work.Personally it's no skin off my back to check both, so why not make everyone happy?
Priorities
Add 馃憤 to pull requests you find important.