Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributor guide: emphasize solving a well-specified problem with each pull request #9073

Merged
merged 1 commit into from Sep 29, 2023

Conversation

fricklerhandwerk
Copy link
Contributor

Motivation

Related to #9072, contributors should be aware of what kind of PR has higher chances of getting reviewed and merged.

Context

this moves the orientation step to the beginning, and adds notes how to
make sure that a problem is well-spefified and the according change more
likely to get accepted

Priorities

Add 👍 to pull requests you find important.

…ch pull request

this moves the orientation step to the beginning, and adds notes how to
make sure that a problem is well-spefified and the according change more
likely to get accepted

Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
@fricklerhandwerk fricklerhandwerk requested a review from a team September 29, 2023 15:23
@roberth roberth merged commit 9c84054 into NixOS:master Sep 29, 2023
8 checks passed
@fricklerhandwerk fricklerhandwerk added documentation contributor-experience Developer experience for Nix contributors labels Oct 2, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-09-29-nix-team-meeting-minutes-90/33774/1

@fricklerhandwerk fricklerhandwerk deleted the pr-guidelines branch October 9, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor-experience Developer experience for Nix contributors documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants