Improve tests and docs prior to refactoring completions #9167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @ncfavier for catching these regressions in my PR. Co-Authored-By: Na茂m Favier <n@monade.li>
github-actions
bot
added
the
with-tests
Ericson2314
changed the title
Ericson2314
force-pushed
the
pre-overhaul-completions
branch
from
b8030c7
to
483d99c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Per #8131 (review), it would be good to add the additional tests and docs prior to making any changes.
Context
#8131 will just become code changes on top of this, then.
Priorities
Add 馃憤 to pull requests you find important.