Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include phase reporting in log file for ssh-ng builds #9280

Merged

Commits on Nov 3, 2023

  1. libstore/ssh-ng: Fix phase reporting in log files.

    When doing local builds, we get phase reporting lines in the log file,
    they look like '@nix {"action":"setPhase","phase":"unpackPhase"}'.
    With the ssh-ng protocol, we do have access to these messages, but since we
    are only including messages of type resBuildLogLine in the logs, the phase
    information does not end up in the log file.
    
    The phase reporting could probably be improved altoghether (it looks like it
    is kind of accidental that these JSON messages for phase reporting show up
    but others don't, just because they are actually emitted by nixpkgs' stdenv),
    but as a first step I propose to make ssh-ng behave in the same way as local builds do.
    r-vdp committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    60b3639 View commit details
    Browse the repository at this point in the history