Clarify SourceAccessor methods should never implicitly follow symlinks
#9306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edolstra Any idea why |
Merged
Ericson2314
force-pushed
the
accessor-no-follow-symlink
branch
from
805a392
to
f9f3bc7
Compare
cole-h
reviewed
Nov 24, 2023
cole-h
reviewed
Nov 24, 2023
Ericson2314
force-pushed
the
accessor-no-follow-symlink
branch
from
472bae2
to
992d32b
Compare
Ericson2314
force-pushed
the
accessor-no-follow-symlink
branch
2 times, most recently
from
fa4beee
to
0e6abe3
Compare
Ericson2314
force-pushed
the
accessor-no-follow-symlink
branch
4 times, most recently
from
705667e
to
c580982
Compare
The code has already been fixed (yay!) so what is left of this commit is just updating the API docs. Co-authored-by: Cole Helbling <cole.e.helbling@outlook.com>
Ericson2314
force-pushed
the
accessor-no-follow-symlink
branch
from
c580982
to
ce4ca57
Compare
|
Now that this is just API docs, I'll just merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The code has already been fixed (yay!) so what is left of this commit is just updating the API docs.
Context
Priorities
Add 馃憤 to pull requests you find important.