Symlink review #9384
Open
Symlink review #9384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They do not involve base-2 exponential effects, so they should be Normal base-10 round numbers.
github-actions
bot
added
with-tests
edolstra
reviewed
Nov 20, 2023
src/libfetchers/input-accessor.cc
Outdated
| while (true) { | ||
| // Basic cycle/depth limit to avoid infinite loops. | ||
| if (++followCount >= maxFollow) | ||
| throw Error("too many levels of symbolic links while traversing the path '%s'; assuming it leads to a cycle after following %d indirections", this->to_string(), maxFollow); |
There was a problem hiding this comment.
Suggested change
| throw Error("too many levels of symbolic links while traversing the path '%s'; assuming it leads to a cycle after following %d indirections", this->to_string(), maxFollow); | |
| throw Error("cycle detected following symlink '%s'", this->to_string()); |
After 1000 links we can safely assume there's a cycle, so no need to be very verbose.
Ericson2314
requested changes
Nov 20, 2023
There was a problem hiding this comment.
As discussed with @roberth in real time, it seems like this code is missing some deleted lines, because shouldn't resolve symlinks have something to do with follow symlinks? (and there is already some symlink code in libeval too I thought.)
Ericson2314
reviewed
Dec 6, 2023
|
Ah I see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Did #9363 (review) myself because we were optimizing for a quick release.
Context
Priorities
Add 馃憤 to pull requests you find important.