Add missing -lrapidcheck fixing build with shared lib
#9431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOS/nixpkgs#269064 makes rapidcheck be build as a shared lib, but that broke Nix because the `-lrapidcheck` was missing. This fixes that (and doesn't break Nix what the library is a static archive as today).
github-actions
bot
added
the
with-tests
Ericson2314
added
backport 2.14-maintenance
Ericson2314
added a commit
to obsidiansystems/nixpkgs
that referenced
this pull request
Nov 22, 2023
13 tasks
|
Successfully created backport PR for |
|
Successfully created backport PR for |
This was referenced Nov 22, 2023
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
github-actions bot
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Nov 22, 2023
Backporting NixOS/nix#9431 (cherry picked from commit 98bdc2b)
Ericson2314
added a commit
to obsidiansystems/nixpkgs
that referenced
this pull request
Nov 22, 2023
Backporting NixOS/nix#9431 (cherry picked from commit 98bdc2b) (cherry picked from commit 640ada0)
dawidd6
pushed a commit
to dawidd6/nixpkgs
that referenced
this pull request
Nov 24, 2023
SuperSandro2000
pushed a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Nov 24, 2023
gepbird
pushed a commit
to gepbird/nixpkgs
that referenced
this pull request
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
NixOS/nixpkgs#269064 makes rapidcheck be build as a shared lib, but that broke Nix because the
-lrapidcheckwas missing. This fixes that (and doesn't break Nix what the library is a static archive as today).Context
NixOS/nixpkgs#269064 found the issue; it now applies this as a patch.
Priorities
Add 馃憤 to pull requests you find important.