Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow getting in a MinGW dev shell #9519

Merged
merged 5 commits into from Dec 11, 2023
Merged

Allow getting in a MinGW dev shell #9519

merged 5 commits into from Dec 11, 2023

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Dec 1, 2023 •
edited

Motivation

A lightweight first step to unblock further Windows experiments.

Context

Depends on #9518

Priorities

Add 👍 to pull requests you find important.

@Ericson2314 Ericson2314 mentioned this pull request Dec 1, 2023
Open
@Ericson2314 Ericson2314 force-pushed the mingw-shell branch 3 times, most recently from 51efd7f to e03e7e9 Compare December 2, 2023 17:57
@Ericson2314
Copy link
Member Author

So a reason I would like to merge this now, even if other windows things are on hold, is that it allows me to track which deps build for Windows or not. Knowing if things break is useful to me because I can go fix them in Nixpkgs which is good prep work that doesn't get in the way of other Nix things.

@dpulls dpulls
Copy link

dpulls bot commented Dec 6, 2023

🎉 All dependencies have been resolved !

@Ericson2314 Ericson2314 mentioned this pull request Dec 6, 2023
Merged
8 tasks
@Ericson2314 Ericson2314 changed the base branch from master to 2.19-maintenance December 6, 2023 17:28
@github-actions github-actions bot added documentation new-cli Relating to the "nix" command with-tests Issues related to testing. PRs with tests have some priority store Issues and pull requests concerning the Nix store repl The Read Eval Print Loop, "nix repl" command and debugger fetching Networking with the outside (non-Nix) world labels Dec 6, 2023
@Ericson2314 Ericson2314 changed the base branch from 2.19-maintenance to master December 6, 2023 17:28
fricklerhandwerk
fricklerhandwerk reviewed Dec 7, 2023
View reviewed changes
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
@Ericson2314
Copy link
Member Author

Does this look good to you now, @fricklerhandwerk?

@Ericson2314
Copy link
Member Author

Nix team meeting notes:

Changes a few small things in an external-ish interface (the name of the cross-build jobs), but very minimal

Fine on the principle, but this adds a new hydra build for mingw, which will be consistently red. Need to change that first, then OK.

@Ericson2314 Ericson2314 added the idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. label Dec 8, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-12-08-nix-team-meeting-minutes-110/36721/1

@Ericson2314
flake.nix: Put some list items on their own line
0b81557 
These things are about to become longer
@Ericson2314
flake.nix: installScriptFor take tarballs not strings
f60c2e8 
Trying to look up keys in multiple places is not nice, better for the
caller to be explicit.
@Ericson2314
flake.nix: Use config not system for cross so we can be a bit mor…
78492cf 
…e precise
@Ericson2314
flake.nix: Make changes so a MinGW dev shell would work
46b98a4
@Ericson2314
flake.nix: Make a MinGW dev shell
b892161 
This requires a `shellCrossSystems` for now, since Nix doesn't actually
build on Windows. This can be dropped once it does.
@Ericson2314
Copy link
Member Author

(I am happy to fix the minor conflicts with the package.nix PR.)

@Ericson2314 Ericson2314 merged commit 5e64961 into NixOS:master Dec 11, 2023
8 checks passed
@Ericson2314 Ericson2314 deleted the mingw-shell branch December 11, 2023 20:02
@fricklerhandwerk fricklerhandwerk added the feature Feature request or proposal label Jan 8, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-on-windows/1113/99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fricklerhandwerk fricklerhandwerk fricklerhandwerk left review comments

@roberth roberth roberth approved these changes

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

@thufschmitt thufschmitt Awaiting requested review from thufschmitt

Assignees

@roberth roberth

Labels
documentation feature Feature request or proposal fetching Networking with the outside (non-Nix) world idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. new-cli Relating to the "nix" command repl The Read Eval Print Loop, "nix repl" command and debugger store Issues and pull requests concerning the Nix store windows with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ericson2314 @nixos-discourse @roberth @fricklerhandwerk