Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't show nix-channel in upgrade instructions #9703

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

fricklerhandwerk
Copy link
Contributor

@fricklerhandwerk fricklerhandwerk commented Jan 6, 2024

Motivation

follow-up to #9679 by @wiki-me

Tested all instructions, in

Context

channels make everything more stateful, and therefore more complicated and potentially confusing, but aren't needed for this task, so don't encourage their use.

Tested instructions on Ubuntu and macOS, fairly easy now thanks to @MatthewCroughan's NixThePlanet!

Priorities and Process

Add 馃憤 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

channels make everything more stateful, and therefore more complicated
and potentially confusing, but aren't needed for this task, so don't encourage their use.
@wiki-me
Copy link
Contributor

wiki-me commented Jan 7, 2024

Doesn't this mean that after upgrading you need to type or copy paste extra parameters for every command?

e.g. instead of:

nix-env -qa neovim

you use:

nix-env -qa neovim -I nixpkgs=channel:nixpkgs-unstable --file ''

That seems like it's too verbose.

@edolstra
Copy link
Member

edolstra commented Jan 7, 2024

As I noted in #9679, these instructions should use nix upgrade-nix rather than document some convoluted and error-prone process with channels.

nix upgrade-nix is not experimental. Like nix repl, it's excepted from the nix-command experimental feature.

@Ericson2314 Ericson2314 changed the title don't show channels in upgrade instructions don't show nix-channel in upgrade instructions Jan 22, 2024
@edolstra edolstra merged commit 16ccca2 into NixOS:master Jan 22, 2024
10 checks passed
@thufschmitt
Copy link
Member

Discussed during the Nix maintainers meeting on 2024-01-22. Approved and merged.

- Doesn't remove nix channels as a concept, but does remove `nix-channel` command
  • @edolstra: Would like to replace with nix upgrade-nix but it's already an improvement.

Merged

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-01-22-nix-team-meeting-minutes-117/38838/1

@fricklerhandwerk fricklerhandwerk deleted the upgrade-no-channel branch February 6, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants