Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add position information to while evaluating the attribute errors in the debugger #9915

Merged
merged 2 commits into from Feb 28, 2024

Conversation

9999years
Copy link
Contributor

Before:

0: while evaluating the attribute 'python311.pythonForBuild.pkgs'
0x600001522598

After:

0: while evaluating the attribute 'python311.pythonForBuild.pkgs'
/nix/store/hg65h51xnp74ikahns9hyf3py5mlbbqq-source/overrides/default.nix:132:27

   131|
   132|       bootstrappingBase = pkgs.${self.python.pythonAttr}.pythonForBuild.pkgs;
      |                           ^
   133|     in

@9999years
Copy link
Contributor Author

TODO: Needs a changelog entry.

@9999years 9999years changed the title Add position information to while evaluating the attribute errors Add position information to while evaluating the attribute errors in the debugger Feb 5, 2024
@tomberek tomberek added the idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. label Feb 14, 2024
Copy link
Contributor

@pennae pennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. a test would be nice to avoid this breaking again, and a rebase to master to make the test not fail (since we're still affected by #9932 in this merge-base)

@tomberek tomberek merged commit ffe67c8 into NixOS:master Feb 28, 2024
10 checks passed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-02-28-nix-team-meeting-129/40499/1

@9999years 9999years deleted the evaluating-attribute-position branch February 29, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants