Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a Python format exception when raising a 'reboot required' Exception #1208

Merged
merged 1 commit into from Dec 31, 2019

Conversation

@jbmusso
Copy link

jbmusso commented Nov 19, 2019

I'm unsure whether I'm fixing a symptom here, but this PR fixes an issue I'm having when attempting to nix-shell myself into latest NixOps, with patch instructions detailed here #1207 applied.

Use case: I'm trying to start an hydra server locally in a VirtualBox VM, following instructions from https://nixos.wiki/wiki/Hydra.

Prior this PR, I was having the following:

Executing setuptoolsCheckPhase
/nix/store/3vb5fxvqjahhgm8h8xii464qhvc8hyg4-python2.7-setuptools-41.4.0/lib/python2.7/site-packages/setuptools/dist.py:484: UserWarning: The version specified ('1.8pre0_abcdef') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.
  "details." % self.metadata.version
running test
......................................
----------------------------------------------------------------------
Ran 38 tests in 0.011s

OK
nixops/deployment.py:750: error:(B Not all arguments converted during string formatting(B
Found 1 error in 1 file (checked 20 source files)(B
builder for '/nix/store/2hcqzy5kkyx1y3ga7wwrbjwxjx02wh7f-nixops-1.8pre0_abcdef.drv' failed with exit code 1
error: build of '/nix/store/2hcqzy5kkyx1y3ga7wwrbjwxjx02wh7f-nixops-1.8pre0_abcdef.drv' failed

I can provide more information if needed.

…ion in Deployment.activate_configs()
@domenkozar domenkozar merged commit 0cd267e into NixOS:master Dec 31, 2019
1 check failed
1 check failed
Travis CI - Pull Request Build Errored
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.